Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Devops] Upgrade to Pandas 2.0.0 #1498

Merged
merged 6 commits into from
Jan 16, 2024
Merged

[Devops] Upgrade to Pandas 2.0.0 #1498

merged 6 commits into from
Jan 16, 2024

Conversation

SimonWittner
Copy link
Collaborator

🔬 Background

  • Conflicts with other packages, which need pandas > 2.0.

🔮 Key changes

  • Relaxing the requirements for pandas-package.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@SimonWittner SimonWittner changed the title [minor] Relaxing Pandas Requirements [Minor] Relaxing Pandas Requirements Dec 20, 2023
@SimonWittner SimonWittner self-assigned this Dec 20, 2023
@SimonWittner SimonWittner added the status: needs review PR needs to be reviewed by Reviewer(s) label Dec 20, 2023
Copy link

github-actions bot commented Dec 20, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 31.6338 31.6338 0.0%
AirPassengers RMSE_val 32.6669 32.6669 0.0%
AirPassengers Loss_val 0.01372 0.01372 0.0%
AirPassengers MAE 6.24137 6.24137 0.0%
AirPassengers RMSE 7.82929 7.82929 0.0%
AirPassengers Loss 0.00063 0.00063 0.0%
AirPassengers time 10.2754 10.65 3.65% ⚠️
YosemiteTemps MAE_val 0.64178 0.64178 0.0%
YosemiteTemps RMSE_val 0.92787 0.92787 0.0%
YosemiteTemps Loss_val 0.0005 0.0005 0.0%
YosemiteTemps MAE 1.092 1.092 0.0%
YosemiteTemps RMSE 1.89124 1.89124 0.0%
YosemiteTemps Loss 0.00155 0.00155 0.0%
YosemiteTemps time 58.2066 61.26 5.25% ⚠️
EnergyPriceDaily MAE_val 5.55889 5.55889 0.0%
EnergyPriceDaily RMSE_val 7.12233 7.12233 0.0%
EnergyPriceDaily Loss_val 0.02829 0.02829 0.0%
EnergyPriceDaily MAE 6.37172 6.37172 0.0%
EnergyPriceDaily RMSE 8.53016 8.53016 0.0%
EnergyPriceDaily Loss 0.02907 0.02907 0.0%
EnergyPriceDaily time 14.7972 15.69 6.03% ⚠️
PeytonManning MAE_val 0.3466 0.3466 0.0%
PeytonManning RMSE_val 0.49808 0.49808 0.0%
PeytonManning Loss_val 0.01752 0.01752 0.0%
PeytonManning MAE 0.34735 0.34735 0.0%
PeytonManning RMSE 0.48788 0.48788 0.0%
PeytonManning Loss 0.01457 0.01457 0.0%
PeytonManning time 20.808 21.7 4.29% ⚠️
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

EnergyPriceDaily

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9493458) 88.33% compared to head (a1c91ed) 88.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1498   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files          38       38           
  Lines        5099     5099           
=======================================
  Hits         4504     4504           
  Misses        595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuigiCerone
Copy link

Hello, any update on this?

@ourownstory ourownstory changed the title [Minor] Relaxing Pandas Requirements [Devops] Upgrade to Pandas 2.0.0 Jan 15, 2024
@ourownstory
Copy link
Owner

Merge once tests pass.

@ourownstory ourownstory merged commit 40268b0 into main Jan 16, 2024
10 of 13 checks passed
@ourownstory ourownstory deleted the pandas_v2 branch January 16, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants