Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cert_check argument to MockMinioClient #36

Merged

Conversation

gatagat
Copy link
Contributor

@gatagat gatagat commented Aug 22, 2024

Change Summary: Minio client accepts cert_check argument to the initializer, this MR adds it to the mock

Related issue number: N/A

Checklist:

  • code is ready
  • add tests
  • all tests passing
  • test coverage did not drop
  • PR is ready for review

See the cert_check argument in the "Parameters" table in https://min.io/docs/minio/linux/developers/python/API.html

@oussjarrousse oussjarrousse changed the base branch from main to version-0.4.16 August 22, 2024 17:17
@oussjarrousse
Copy link
Owner

Thank you for your pull request. It looks fine.
I just need to run make some checks and maybe add a test for the interface.
I will finalise it over the weekend.

@oussjarrousse oussjarrousse merged commit 3ce1f45 into oussjarrousse:version-0.4.16 Aug 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants