Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Popup Style Attributes: Place #112

Closed
wants to merge 1 commit into from

Conversation

shubham-kaushal
Copy link
Member

No description provided.

@tenphi
Copy link
Collaborator

tenphi commented Dec 22, 2020

I don't see any reason we make the popup to behave visually like the popuplistbox. In most cases, a popup should be centered.

@shubham-kaushal
Copy link
Member Author

To have consistency in the default styling, it's important.

The current styling looks a little odd.
image

@shubham-kaushal
Copy link
Member Author

image
Looks Better

@shubham-kaushal
Copy link
Member Author

shubham-kaushal commented Dec 22, 2020

Or we need to have a custom bottom radius only, no top radius. In case if you want to have the same placement.

Note: It still needs a dynamic placement feature #113

@tenphi
Copy link
Collaborator

tenphi commented Mar 1, 2021

I got the idea. I will make some changes in another branch.

@tenphi tenphi closed this Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants