Add missing code to TextDecoder "Invalid byte sequence" error (#9700

) * Fix missing `ERR_ENCODING_INVALID_ENCODED_DATA` code in TextDecoder * Update text-decoder.test.js --------- Co-authored-by: Jarred Sumner <[email protected]>
oven-sh · Mar 29, 2024 · 4512a04 · 4512a04
1 parent 1ad6a3d
commit 4512a04
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/bun.js/webcore/encoding.zig b/src/bun.js/webcore/encoding.zig
@@ -652,10 +652,9 @@ pub const TextDecoder = struct {
                     } else |err| {
                         switch (err) {
                             error.InvalidByteSequence => {
-                                globalThis.throwValue(
-                                    globalThis.createTypeErrorInstance("Invalid byte sequence", .{}),
-                                );
-                                return JSValue.zero;
+                                const type_error = globalThis.createErrorInstanceWithCode(.ERR_ENCODING_INVALID_ENCODED_DATA, "Invalid byte sequence", .{});
+                                globalThis.throwValue(type_error);
+                                return .zero;
                             },
                             error.OutOfMemory => {
                                 globalThis.throwOutOfMemory();

diff --git a/test/js/web/encoding/text-decoder.test.js b/test/js/web/encoding/text-decoder.test.js
@@ -230,7 +230,14 @@ describe("TextDecoder", () => {
     const decoder = new TextDecoder("utf-8", { fatal: true });
     expect(() => {
       decoder.decode(new Uint8Array([0xc0])); // Invalid UTF8
-    }).toThrow(TypeError);
+    }).toThrow(Error);
+    let err;
+    try {
+      decoder.decode(new Uint8Array([0xc0, 0x80])); // Invalid UTF8
+    } catch (e) {
+      err = e;
+    }
+    expect(err.code).toBe("ERR_ENCODING_INVALID_ENCODED_DATA");
   });
 
   it("should not trim invalid byte sequences when fatal is false", () => {