-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: let the platform decide for login and registration #91
Conversation
Thanks for the PR. I have tested with normal auth flow and it's working fine. Could you please elaborate on the following questions related to tpa:
If you can share a working video of it with TPA, it will greatly help me understand the flow with TPA. or let me know how to test tpa on my system. For now, I've added |
Yes, you can test if you have a TPA setup and add
I don't get it. OpenedX covers all sorts of scenarios and all of them are handled with login/register views. in this scenario, it's not possible if you want users to not interact with authn mfe and use your desired TPA directly (Good UX). Instead, you need to let them know that after login, you need to click on another button to login (Bad UX) Here is a video of SAML login setup on one of our test orgs. Screencast.from.06-14-2024.02.12.27.PM.webm |
Awesome! Thanks a lot for sharing the video. It clears things up much better. I'll appreciate it if you could do the below tasks in this PR.
|
No Problem. |
8ceaba2
to
87f11f6
Compare
Here you go. |
We force users to go to authentication mfe for login/registration and prevent login behavior tweaks like having THIRD_PARTY_AUTH_HINT in your site configuration which redirects users to a TPA when they visit /login. Close overhangio#87
87f11f6
to
be83853
Compare
This will