fix: Fix tutor when using docker compose 2.24.1 #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
requested changes
Jan 25, 2024
There was a problem hiding this comment.
Thanks for this PR! We do want to have this fix in tutor native, as the duplicate volume declarations are completely useless. Please just address the following items:
- Can you please rebase your PR to target the master branch, instead of nightly?
- Add a changelog entry with
make changelog-entryhttps://docs.tutor.edly.io/tutor.html#contributing
xitij2000
force-pushed
the
kshitij/fix-tutor-docker-compose
branch
from
21d6c88 to
a7f267e
Compare
xitij2000
force-pushed
the
kshitij/fix-tutor-docker-compose
branch
from
a7f267e to
231d517
Compare
xitij2000
force-pushed
the
kshitij/fix-tutor-docker-compose
branch
from
231d517 to
f5a8131
Compare
regisb
reviewed
Jan 29, 2024
Sure, it's ready for review. |
regisb
approved these changes
Jan 30, 2024
|
Thanks for your help @xitij2000 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #992