Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle allowedIPs parameters in CK building #132

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

deathiop
Copy link
Contributor

@deathiop deathiop commented Jun 7, 2024

No description provided.

ovh/client.py Outdated
"""
Create a new "consumer key" identifying this application's end user. API
will return a ``consumerKey`` and a ``validationUrl``. The end user must
visit the ``validationUrl``, authenticate and validate the requested
``access_rules`` to link his account to the ``consumerKey``. Once this
is done, he may optionally be redirected to ``redirect_url`` and the
application can start using the ``consumerKey``.
application can start using the ``consumerKey``. If adding a ``allowedIPs``
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
application can start using the ``consumerKey``. If adding a ``allowedIPs``
application can start using the ``consumerKey``. If adding an ``allowedIPs``

ovh/client.py Outdated
"""
Create a new "consumer key" identifying this application's end user. API
will return a ``consumerKey`` and a ``validationUrl``. The end user must
visit the ``validationUrl``, authenticate and validate the requested
``access_rules`` to link his account to the ``consumerKey``. Once this
is done, he may optionally be redirected to ``redirect_url`` and the
application can start using the ``consumerKey``.
application can start using the ``consumerKey``. If adding a ``allowedIPs``
parameter, the generated credentials will only be usable from these IPS.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
parameter, the generated credentials will only be usable from these IPS.
parameter, the generated credentials will only be usable from these IPs.

amstuta
amstuta previously approved these changes Jun 7, 2024
Signed-off-by: Adrien Barreau <[email protected]>
@deathiop deathiop merged commit b3c6154 into ovh:master Jun 7, 2024
7 checks passed
@deathiop deathiop deleted the allowed-ips branch June 7, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants