feat: handle Client Credential OAuth2 authentication method #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathiop
requested review from
rbeuque74,
a-beudin,
amstuta and
mxpetit
as code owners
deathiop
force-pushed
the
origin/oauth2
branch
3 times, most recently
from
ecd6660
to
60ca132
Compare
amstuta
reviewed
Jun 27, 2024
README.rst
Outdated
| @@ -104,12 +104,15 @@ it looks like: | |||
| ; uncomment following line when writing a script application | |||
| ; with a single consumer key. | |||
| ;consumer_key=my_consumer_key | |||
| ; uncomment to unable oauth2 authentication | |||
There was a problem hiding this comment.
Suggested change
| ; uncomment to unable oauth2 authentication | |
| ; uncomment to enable oauth2 authentication |
ovh/client.py
Outdated
| ``consumer_key`` uniquely identifies your application's end user without | ||
| requiring his personal password. | ||
| When using OAuth2 authentication, ``client_id`` and ``client_secret`` | ||
| will be used to initiate a 2-Legged OAuth2 flow. |
There was a problem hiding this comment.
maybe use client credentials flow instead of 2-Legged
ovh/oauth2.py
Outdated
| self.register_compliance_hook("access_token_response", self.save_error) | ||
| self.register_compliance_hook("refresh_token_response", self.save_error) | ||
|
|
||
| # This hijacks the |
deathiop
force-pushed
the
origin/oauth2
branch
2 times, most recently
from
21aaf1e
to
e4bebb2
Compare
amstuta
approved these changes
Jun 28, 2024
deathiop
changed the title
Signed-off-by: Adrien Barreau <[email protected]>
deathiop
changed the title
marie-j
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.