Skip to content

Commit

Permalink
Enable reviews. Added annotations for imagesnap and AVFoundation (#107)
Browse files Browse the repository at this point in the history
Signed-off-by: Prabhu Subramanian <[email protected]>
  • Loading branch information
prabhu authored Jun 17, 2024
1 parent 9fa2f9d commit 8ad8714
Show file tree
Hide file tree
Showing 4 changed files with 200 additions and 172 deletions.
2 changes: 1 addition & 1 deletion blint/analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ def _process_files(self, f, reports_dir, no_reviews, suggest_fuzzables):
if finding := run_checks(f, metadata):
self.findings += finding
# Perform symbol reviews
if no_reviews:
if not no_reviews:
self.do_review(exe_name, f, metadata)
# Suggest fuzzable targets
if suggest_fuzzables and (fuzzdata := run_prefuzz(metadata)):
Expand Down
28 changes: 28 additions & 0 deletions blint/data/annotations/review_symbols_macho.yml
Original file line number Diff line number Diff line change
Expand Up @@ -611,3 +611,31 @@ rules:
- SecPolicyGetTypeID
- SecPolicyCreateWithProperties
- SecPolicyCopyProperties
- id: IMAGE_SNAP_API
title: Image Snap API functions used
summary: Capture Images from iSight and other video sources
description: |
ImageSnap is a Public Domain command-line tool that lets you capture still images from an iSight or other video source.
patterns:
- ImageSnap defaultVideoDevice
- ImageSnap saveSingleSnapshotFrom
- ImageSnap setUpSessionWithDevice
- ImageSnap getReadyToTakePicture
- ImageSnap takeSnapshotWithFilename
- ImageSnap captureSession
- ImageSnap captureDeviceInput
- ImageSnap captureStillImageOutput
- ImageSnap currentImageBuffer
- ImageSnap videoConnection
- id: AVFOUNDATION_API
title: AVFoundation functions used
summary: Work with audiovisual assets, control device cameras, process audio, and configure system audio interactions
description: |
AVFoundation combines several major technology areas that together encompass a wide range of tasks for inspecting, playing, capturing, and processing audiovisual media on Apple platforms.
patterns:
- AVFoundation::_
- AVCaptureSession
- AVMediaTypeMuxed
- AVMediaTypeVideo
- AVVideoCodecJPEG
- AVVideoCodecKey
Loading

0 comments on commit 8ad8714

Please sign in to comment.