Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc: multi-language search in EntitySelector #4352

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Dec 22, 2024

Proof of concept for #4256.

@owidbot
Copy link
Contributor

owidbot commented Dec 22, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-entity-selector-multi-lang-s

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-12-22 21:13:29 UTC
Execution time: 1.22 seconds

Copy link

github-actions bot commented Jan 6, 2025

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Jan 6, 2025
@marcelgerber
Copy link
Member Author

We talked about this some in our data viz call today.

Even though there are some rough edges to this, we think this is an improvement to the status quo. I want to chisel this into a nice PR in a future cooldown.

One thing that's a bit cumbersome in the current implementation is that our current FuzzySeach implementation doesn't easily allow for multiple words/aliases to map to the same entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants