Fix crash when a network error occurs during resource retrieval (#12045)

owncloud · Jan 27, 2025 · 39d2284 · 39d2284
1 parent 7e67256
commit 39d2284
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/changelog/unreleased/12045 b/changelog/unreleased/12045
@@ -0,0 +1,7 @@
+Bugfix: Fix crash after resource job fails
+
+When a network error occurs while fetching a resource (e.g. a space
+image), no icon is available, and a crash would occur. This is fixed by
+returning an empty icon.
+
+https://github.com/owncloud/client/pull/12045
diff --git a/src/libsync/networkjobs/resources.cpp b/src/libsync/networkjobs/resources.cpp
@@ -72,8 +72,12 @@ void ResourceJob::finished()
 
 QIcon ResourceJob::asIcon() const
 {
+    if (_cacheKey.isEmpty()) {
+        // This can happen when a network error occurred when retrieving the icon.
+        return {};
+    }
+
     // storing the file on disk enables Qt to apply some optimizations (e.g., caching of rendered pixmaps)
-    Q_ASSERT(!_cacheKey.isEmpty());
     return QIcon(_cache->path(_cacheKey));
 }