Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bypass Qt's QFile::encodeName() in csync #12039

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jan 23, 2025

ToDo

  • extract commits as individual reasonable PRs
  • fix failing windows test @erikjv
  • implement test case for nfd/nfc encoded mkpath
  • implement test case for nfd/nfc encoded rename

@erikjv erikjv force-pushed the fix/no-normalization-macos branch from 849a1ca to 1b2d2ca Compare January 23, 2025 16:56
@DeepDiver1975 DeepDiver1975 force-pushed the fix/no-normalization-macos branch 3 times, most recently from a70dda3 to 980bd4a Compare January 29, 2025 16:59
@erikjv
Copy link
Collaborator

erikjv commented Jan 30, 2025

I moved "Clarify propagator job descriptions" out as a seperate PR: #12050 . We can merge the fromDisk fix into the commit where it is implemented. But other than that, I think we should keep this as 1 PR.

@erikjv erikjv force-pushed the fix/no-normalization-macos branch from 980bd4a to a74d10d Compare January 30, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants