Skip to content

Commit

Permalink
Add missing certTrusted condition for ldap-ca volume (#828)
Browse files Browse the repository at this point in the history
* Add missing certTrusted condition for ldap-ca volume
* fix whitespace in ldap-ca condition on groups service that differed from graph and users service

---------

Co-authored-by: Willy Kloucek <[email protected]>
  • Loading branch information
Joker9944 and wkloucek authored Dec 6, 2024
1 parent b05a650 commit d244e33
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion charts/ocis/templates/graph/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ spec:
emptyDir: {}
{{ end }}
- name: ldap-ca
{{ if not .Values.features.externalUserManagement.enabled }}
{{ if or (not .Values.features.externalUserManagement.enabled) (not .Values.features.externalUserManagement.ldap.certTrusted) }}
secret:
secretName: {{ include "secrets.ldapCASecret" . }}
{{ else }}
Expand Down
4 changes: 2 additions & 2 deletions charts/ocis/templates/groups/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ spec:
value: {{ .Values.features.externalUserManagement.ldap.uri | quote }}
{{ end }}
- name: GROUPS_LDAP_CACERT
{{ if or (not .Values.features.externalUserManagement.enabled) ( not .Values.features.externalUserManagement.ldap.certTrusted) }}
{{ if or (not .Values.features.externalUserManagement.enabled) (not .Values.features.externalUserManagement.ldap.certTrusted) }}
value: /etc/ocis/ldap-ca/ldap-ca.crt
{{ else }}
value: "" # no cert needed
Expand Down Expand Up @@ -167,7 +167,7 @@ spec:
- name: tmp-volume
emptyDir: {}
- name: ldap-ca
{{ if or (not .Values.features.externalUserManagement.enabled) ( not .Values.features.externalUserManagement.ldap.certTrusted) }}
{{ if or (not .Values.features.externalUserManagement.enabled) (not .Values.features.externalUserManagement.ldap.certTrusted) }}
secret:
secretName: {{ include "secrets.ldapCASecret" . }}
{{ else }}
Expand Down

0 comments on commit d244e33

Please sign in to comment.