Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle quick link copy action in resources list on safari #10401

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LukasHirt
Copy link
Collaborator

Description

Currently WIP. Generally speaking we need to pass any async functions happening before the clipboard write into the clipboard logic. Otherwise safari looses user context and does not consider it user action.

Related Issue

Motivation and Context

Users can copy quick links on safari.

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • handle link creation via modal
  • handle link creation without modal
  • clean up

@LukasHirt LukasHirt added Type:Bug Something isn't working Status:In-Progress Category:Technical Technical ehancements labels Jan 24, 2024
@LukasHirt LukasHirt self-assigned this Jan 24, 2024
Copy link

update-docs bot commented Jan 24, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Technical Technical ehancements Status:In-Progress Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link-copy file-list-action not working in Safari
1 participant