Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort roles in role dropdown according to backend #11916

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Nov 15, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Nov 15, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Nov 15, 2024

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my limited understanding of the web code, this looks good.

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Nov 15, 2024

@micbar For now yes... But as I mentioned, the roles that are displayed are from the /roleDefinitions endpoint, we do match them with the allowedRoles from the /permissions endpoint tough

somehow the @libre.graph.weight is the same for view and secure view (both has 1)
image

While it differs from the /permissions endpoint

image

@AlexAndBear AlexAndBear merged commit df416ec into master Nov 18, 2024
3 checks passed
@AlexAndBear AlexAndBear deleted the issues/11915 branch November 18, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SharingNG] Unified Roles are not sorted by weight
3 participants