Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(semantic): change IndexMap to Vec for Bindings #8008

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 19, 2024

No description provided.

@Boshen Boshen requested a review from Dunqing as a code owner December 19, 2024 03:11
@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 19, 2024
Copy link
Member Author

Boshen commented Dec 19, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen marked this pull request as draft December 19, 2024 03:12
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #8008 will degrade performances by 31.88%

Comparing 12-19-refactor_semantic_change_indexmap_to_vec_for_bindings_ (e510c7b) with main (0a38eea)

Summary

⚡ 1 improvements
❌ 7 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 12-19-refactor_semantic_change_indexmap_to_vec_for_bindings_ Change
linter[checker.ts] 2.7 s 2.9 s -8.77%
semantic[antd.js] 116.7 ms 171.3 ms -31.88%
semantic[cal.com.tsx] 28.3 ms 40.2 ms -29.72%
semantic[checker.ts] 71.1 ms 102.9 ms -30.88%
semantic[pdf.mjs] 19.2 ms 18.5 ms +3.91%
transformer[antd.js] 50.6 ms 61.8 ms -18.22%
transformer[cal.com.tsx] 34.8 ms 49.4 ms -29.61%
transformer[checker.ts] 21.6 ms 24.9 ms -13.13%

@Boshen Boshen force-pushed the 12-19-refactor_semantic_change_indexmap_to_vec_for_bindings_ branch from 14e417a to e510c7b Compare December 19, 2024 03:52
@Boshen Boshen closed this Dec 19, 2024
@Boshen Boshen deleted the 12-19-refactor_semantic_change_indexmap_to_vec_for_bindings_ branch January 14, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant