Retyping #152
Open
Retyping #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dr7ana
commented
Dec 4, 2024
•
dr7ana
commented
- Based on 0RTT, Early data, session ticketing, key verification, stateless reset #153 (previously 0RTT, Early data, session ticketing, key verification, stateless reset #147)
dr7ana
force-pushed
the
retyping
branch
4 times, most recently
from
97d80ec to
b61203e
Compare
- By passing `opt::disable_key_verification` in calls to `Endpoint::{listen,connect}(...)` the application can decide whether to use key verification for inbound or outbound connections.
- can be toggled on/off, bespoke types for handling generation and storage - improvements, better handling, callbacks
- ping binaries added to test timing - more thoughtful compile time checking
The copy and move constructors/operators are a decent amount of complexity keeping track of pointers that really isn't needed because we nearly always want these held inside a unique_ptr, and so it simplifies things to just enforce that everywhere and fix the two occurances that held in a value and then sort of mutated into a unique_ptr. This also lets us make the key data const, which gives us better safety assurances for using it as the key of a map (as we currently are). Also makes the private fields actually private, along with the constructors (to enforce all usage now go through make). Also dropped some unused comparison & hashing functions.
- added RAII gnutls_datum object, used where needed. Must be careful, can double free if the memory is owned by another object or held within ngtcp2 - misc fixes from oxen-io#147
dr7ana
force-pushed
the
retyping
branch
3 times, most recently
from
4a2839a to
32db890
Compare
jagerman
reviewed
Jan 17, 2025
dr7ana
force-pushed
the
retyping
branch
4 times, most recently
from
1d2cb55 to
2b477e9
Compare
dr7ana
force-pushed
the
retyping
branch
2 times, most recently
from
3d6f175 to
e8330b5
Compare
- cmake configuration to force fmt > 10 when compiling with clang-19 - misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.