Remove ackable_work
; ack immediately instead
#1552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long time ago, one task accumulated ackable jobs into
Downstairs::ackable_work
and a different task periodically read out that set and sent acks back to the guest.The tasks have long since been consolidated, but the
ackable_work
set remained.This PR removes the
ackable_work
set, acking jobs immediately when they are ready. It's a significant LOC simplification, because it's removing intermediate state (which previously had to be checked in unit tests).There's one subtlety in handling live-repair: previously, the live-repair check would look in
ackable_work
to see if the next job was ackable, which indicates that live-repair can continue. Now, we update theLiveRepairState
directly inDownstairs::ack
, storing a result for the pending live-repair job.