New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions to get measurements out of the log #228

Merged

mkeeter merged 1 commit into main from mkeeter/measurement-log-index

Feb 28, 2025

Contributor

mkeeter commented Feb 28, 2025

Right now, it is literally impossible to get anything out of a MeasurementLog: its members are private, and it has no accessor functions.

This PR adds len(), is_empty(), and core::ops::Index implementations.


          Add functions to get measurements out of the log

17468a5

mkeeter requested review from flihp and labbott

February 28, 2025 20:25

labbott reviewed

View reviewed changes

Contributor

labbott left a comment

LGTM, I'll also let Phil give a review in case there's some quirk of the implementation

flihp approved these changes

View reviewed changes

mkeeter merged commit f1ccb0e into main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet