Detect tail calls in stack size estimation #2005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the deepest stack involves a tail call. For example, consider
write_fmt
, which has no stack of its own and branches directly tocore::fmt::write
(instead of usingbl
):This PR adds basic tail call support to the disassembler. The main effect is adding 80 bytes to panic stack depth.
Before:
After:
Unfortunately, this does not detect the stack overflow in #2004, which happens during dynamic dispatch. Still, it's a step in the right direction!