[faux-mgs] Add --sp-sim-addr CLI flag #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use
faux-mgs
to talk tosp-sim
running on localhost fails in a confusing way wheresp-sim
gets packets fromfaux-mgs
, butfaux-mgs
rejects the response because they come back with a scope ID of 0:I think this is because scope IDs are only provided for link-local addresses? The behavior here is the same on Linux and illumos.
This PR adds a new flag specifically for talking to the simulator, which goes through the test path we created for MGS to do this same thing: