Share read write #247
Open
Share read write #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor gets the code responsible for dumping secrets to the printer out of the HSM module. Additionally this moves all code driving user interaction out of the HSM module. This commit also defines a new type for the Feldman Verifier. This is useful for passing things around w/o having to specify a pile of generics. This uncovered a bug on the `verify_shares` test case that required we regenerate some test data.
This refactor gets the code responsible for importing secrets from the user. This gets a significant amount of code driving interaction with the user out of the `hsm` module and into one dedicated to the purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More cleanup work, this time moving the code that exports / imports secrets like passwords & key shares into its own module. This is in anticipation of future work to support new I/O methods not the printer.