Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dendrite to fb571dc #6119

Closed
wants to merge 3 commits into from
Closed

Conversation

oxide-reflector-bot[bot]
Copy link
Contributor

@oxide-reflector-bot oxide-reflector-bot bot commented Jul 18, 2024

Updated dendrite to commit fb571dc.

@oxide-reflector-bot oxide-reflector-bot bot changed the title Update dendrite to 78c53d8 Update dendrite to fb571dc Jul 19, 2024
@karencfv
Copy link
Contributor

@bnaecker Do you mind taking a look at why https://github.com/oxidecomputer/dendrite/pull/997 isn't passing the deploy test?

My dendrite commit requires #5593 to pass, so I'm expecting the deploy job to fail here. I'm planning to update dendrite on my PR directly.

@bnaecker
Copy link
Collaborator

bnaecker commented Jul 19, 2024 via email

@bnaecker
Copy link
Collaborator

bnaecker commented Jul 19, 2024 via email

@bnaecker
Copy link
Collaborator

@karencfv The log from the failing check updating to dendrite#997 can be found here. It indicates that Nexus didn't come up in the timeout we've set of 5 minutes. Dendrite came up fine. I would probably call this a flake. We've seen it a few times before, though we don't have the luxury of re-running it because we've already moved Dendrite past it.

The next update, to fb571dc6512b24a777c5a9b2927a50501f6be297, failed here. As I mentioned yesterday, this appears to be failing because dpd and tfportd are now dependent on the zone-network-setup SMF service, which is missing. They will not be able to start without it.

All that said, this PR is a convenience. If you are planning to update the pinned Dendrite commit that Omicron points to in your PR, I would just close this PR and do that yourself.

@karencfv
Copy link
Contributor

@karencfv The log from the failing check updating to dendrite#997 can be found here. It indicates that Nexus didn't come up in the timeout we've set of 5 minutes. Dendrite came up fine. I would probably call this a flake. We've seen it a few times before, though we don't have the luxury of re-running it because we've already moved Dendrite past it.

Thanks! Ah, ok. So this flake has been seen before then. I think you can still run the deploy job even if the PR has moved on. I'm attempting to run the deploy job from that commit again here https://github.com/oxidecomputer/omicron/runs/27723024220.

The next update, to fb571dc6512b24a777c5a9b2927a50501f6be297, failed here. As I mentioned yesterday, this appears to be failing because dpd and tfportd are now dependent on the zone-network-setup SMF service, which is missing. They will not be able to start without it.

Yes, like I mentioned in #6119 (comment) , I was expecting my commit to fail here because of the aforementioned dependencies and I had already planned to close this PR and update dendrite on my PR directly.

@karencfv
Copy link
Contributor

superseded by #5593

@karencfv karencfv closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants