Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a boot device field to Instance, forward along as appropriate #6585

Merged
merged 44 commits into from
Oct 1, 2024
Merged

Add a boot device field to Instance, forward along as appropriate #6585

merged 44 commits into from
Oct 1, 2024

Commits on Sep 17, 2024

  1. first brush at processing primary boot device selection in control plane

    @iximeow
    iximeow committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    94908e7 View commit details
    Browse the repository at this point in the history

  2. actually set up crdb properly with new column

    @iximeow
    iximeow committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    55c2fe2 View commit details
    Browse the repository at this point in the history

  3. rustfmt

    @iximeow
    iximeow committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3e5ba81 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. make boot_device uuid, constrain disk detach and boot_device assignment

    @iximeow
    iximeow committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1a70c9f View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. generalize {set,clear}_boot_device into other instance setting changes 

    additionally, add a general-purpose instance update endpoint to change
the boot device for an existing instance, as well as tests that the
constraints around what we can do with boot devices and the boot device
field are checked.
    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    60993d3 View commit details
    Browse the repository at this point in the history

  2. setting boot device does not have the instance_attach_disk problem 

    if the disk is not in the same project, it will not be attached, so it
will not be eligible to be the boot device.
    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    097a961 View commit details
    Browse the repository at this point in the history

  3. cleanup, also figured out why rustfmt wasnt respecting 80col

    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    5f8844c View commit details
    Browse the repository at this point in the history

  4. rustfmt, line wrapping

    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    7b7c290 View commit details
    Browse the repository at this point in the history

  5. first_async introduced some types issues, oops 

    also no longer need authz_project_disk
    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    a059312 View commit details
    Browse the repository at this point in the history

  6. unwind deteching if a boot disk is present and unattached vs nonexistant 

    might return to this later, but as-is i've gotten something wrong with
the query..
    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    b7833bf View commit details
    Browse the repository at this point in the history

  7. allow reconfiguration of instances in Creating 

    (and fix a few test references to now-boot_device_id)
    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    53873aa View commit details
    Browse the repository at this point in the history

  8. include the field rename...

    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    cae16ea View commit details
    Browse the repository at this point in the history

  9. line wrapping, update nexus_tags.txt

    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    662401d View commit details
    Browse the repository at this point in the history

  10. update endpoint is a PUT on the resource, add unauthorized coverage

    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    efb34a5 View commit details
    Browse the repository at this point in the history

  11. s/boot_device/boot_disk/g

    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    4eb1ff5 View commit details
    Browse the repository at this point in the history

  12. and the column gets a s/boot_disk/boot_disk_id/g

    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    da9e29c View commit details
    Browse the repository at this point in the history

  13. how did that not rustfmt before???

    @iximeow
    iximeow committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    1b21005 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. update openapi documents

    @iximeow
    iximeow committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1537af9 View commit details
    Browse the repository at this point in the history

  2. reconfigure_instance -> instance_reconfigure

    @iximeow
    iximeow committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    31a1ba0 View commit details
    Browse the repository at this point in the history

  3. a few more words on why set_boot_disk is weird

    @iximeow
    iximeow committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bf36e98 View commit details
    Browse the repository at this point in the history

  4. might as well assert on that error

    @iximeow
    iximeow committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5a7863f View commit details
    Browse the repository at this point in the history

  5. overzealous boot_disk_id in tests

    @iximeow
    iximeow committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    73069f2 View commit details
    Browse the repository at this point in the history

  6. temp

    @iximeow
    iximeow committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    60d7972 View commit details
    Browse the repository at this point in the history

  7. use propolis-client's new BootSettings type

    @iximeow
    iximeow committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a4688d8 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge branch 'main' into ixi/boot-order

    @iximeow
    iximeow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ed5f0e5 View commit details
    Browse the repository at this point in the history

  2. update openapi documents post-merge

    @iximeow
    iximeow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e4e299a View commit details
    Browse the repository at this point in the history

  3. clippy

    @iximeow
    iximeow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    02e76de View commit details
    Browse the repository at this point in the history

  4. do update propolis...

    @iximeow
    iximeow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6b65dfe View commit details
    Browse the repository at this point in the history

  5. didnt even know that test was there..

    @iximeow
    iximeow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    35be25f View commit details
    Browse the repository at this point in the history

  6. test merge fixup as well

    @iximeow
    iximeow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d6b1e73 View commit details
    Browse the repository at this point in the history

  7. more clippy fixes (in tests! just run cargo xtask clippy.)

    @iximeow
    iximeow committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    93a0268 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. other half of the "boot_disk_id" migration + test that it migrates right

    @iximeow
    iximeow committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    886f735 View commit details
    Browse the repository at this point in the history

  2. better API documentation on the boot_disk field

    @iximeow
    iximeow committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    996687e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into ixi/boot-order-correc… 

    …t-propolis
    @iximeow
    iximeow committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7d599b3 View commit details
    Browse the repository at this point in the history

  4. documentation for kinda-unsatisfying add-instance-boot-disk

    @iximeow
    iximeow committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0bd0919 View commit details
    Browse the repository at this point in the history

  5. not those though

    @iximeow
    iximeow committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e8c8554 View commit details
    Browse the repository at this point in the history

  6. resolved schema change conflict incompletely

    @iximeow
    iximeow committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9c04206 View commit details
    Browse the repository at this point in the history

  7. updating a wrong-state instance is conflict

    @iximeow
    iximeow committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ef268bf View commit details
    Browse the repository at this point in the history

  8. good to have boot disk listed in omdb

    @iximeow
    iximeow committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    70344ad View commit details
    Browse the repository at this point in the history

  9. speed limit 80

    @iximeow
    iximeow committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    73882b5 View commit details
    Browse the repository at this point in the history

  10. clippy/fmt

    @iximeow
    iximeow committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    404801c View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge branch 'main' into ixi/boot-order 

    also update propolis to the matching version now that #756 is merged
    @iximeow
    iximeow committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    28cdc3d View commit details
    Browse the repository at this point in the history

  2. instance create API: boot disk name -> boot disk attachment 

    "you gotta run cargo xtask openapi generate"
    @iximeow
    iximeow committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8b22d56 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ixi/boot-order

    @iximeow
    iximeow committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    899f781 View commit details
    Browse the repository at this point in the history