[reconfigurator] Add planner support for starting new Crucible pantries #6836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing on a4x2: After handoff to Nexus, I confirmed there were three pantry zones running and present in the internal DNS records: I then used I made this edited blueprint the target, then waited for that pantry zone to be expunged. It was removed from DNS, as expected: Running the planner placed a new pantry (on the same sled where I expunged the pantry, which is as expected: I only set up a4x2 with three sleds, and after expunging the existing pantry, we had 2 sleds with 1 pantry each and 1 sled with 0, so we placed the new pantry on the sled with 0): After making this the target and waiting a bit, we were back to three pantries in DNS: and the new zone was up and running: and we can reach its status endpoint from another zone where internal DNS is set up amenably for curl: |
plotnick
approved these changes
Oct 11, 2024
Comment on lines
-47
to
-48
| // Zones that we should place but don't yet. | ||
| | BlueprintZoneType::CruciblePantry(_) |
There was a problem hiding this comment.
🎆
A lot of work by a lot of people went into removing this comment. Nice job everyone!
Ah interesting, the tabular output changed because |
Haha, I didn't even realize this; convenient that "shifted" works for this and also the meaning I meant. Taking this sled change as an example: - ------------------------------------------------------------------------------------------
- zone type zone id disposition underlay IP
- ------------------------------------------------------------------------------------------
- clickhouse 44afce85-3377-4b20-a398-517c1579df4d in service fd00:1122:3344:103::23
- crucible 38b047ea-e3de-4859-b8e0-70cac5871446 in service fd00:1122:3344:103::2c
- crucible 4644ea0c-0ec3-41be-a356-660308e1c3fc in service fd00:1122:3344:103::2b
- crucible 55f4d117-0b9d-4256-a2c0-f46d3ed5fff9 in service fd00:1122:3344:103::24
- crucible 5c6a4628-8831-483b-995f-79b9126c4d04 in service fd00:1122:3344:103::27
- crucible 6a01210c-45ed-41a5-9230-8e05ecf5dd8f in service fd00:1122:3344:103::28
- crucible 79552859-fbd3-43bb-a9d3-6baba25558f8 in service fd00:1122:3344:103::25
- crucible 90696819-9b53-485a-9c65-ca63602e843e in service fd00:1122:3344:103::26
- crucible c99525b3-3680-4df6-9214-2ee3e1020e8b in service fd00:1122:3344:103::29
- crucible f42959d3-9eef-4e3b-b404-6177ce3ec7a1 in service fd00:1122:3344:103::2a
- crucible fb36b9dc-273a-4bc3-aaa9-19ee4d0ef552 in service fd00:1122:3344:103::2d
- internal_dns 7004cab9-dfc0-43ba-92d3-58d4ced66025 in service fd00:1122:3344:1::1
- internal_ntp c81c9d4a-36d7-4796-9151-f564d3735152 in service fd00:1122:3344:103::21
- nexus b2573120-9c91-4ed7-8b4f-a7bfe8dbc807 in service fd00:1122:3344:103::22
+ ---------------------------------------------------------------------------------------------
+ zone type zone id disposition underlay IP
+ ---------------------------------------------------------------------------------------------
+ clickhouse 44afce85-3377-4b20-a398-517c1579df4d in service fd00:1122:3344:103::23
+ crucible 38b047ea-e3de-4859-b8e0-70cac5871446 in service fd00:1122:3344:103::2c
+ crucible 4644ea0c-0ec3-41be-a356-660308e1c3fc in service fd00:1122:3344:103::2b
+ crucible 5c6a4628-8831-483b-995f-79b9126c4d04 in service fd00:1122:3344:103::27
+ crucible 6a01210c-45ed-41a5-9230-8e05ecf5dd8f in service fd00:1122:3344:103::28
+ crucible 79552859-fbd3-43bb-a9d3-6baba25558f8 in service fd00:1122:3344:103::25
+ crucible 90696819-9b53-485a-9c65-ca63602e843e in service fd00:1122:3344:103::26
+ crucible a9a6a974-8953-4783-b815-da46884f2c02 in service fd00:1122:3344:103::2e
+ crucible c99525b3-3680-4df6-9214-2ee3e1020e8b in service fd00:1122:3344:103::29
+ crucible f42959d3-9eef-4e3b-b404-6177ce3ec7a1 in service fd00:1122:3344:103::2a
+ crucible fb36b9dc-273a-4bc3-aaa9-19ee4d0ef552 in service fd00:1122:3344:103::2d
+ crucible_pantry 55f4d117-0b9d-4256-a2c0-f46d3ed5fff9 in service fd00:1122:3344:103::24
+ internal_dns 7004cab9-dfc0-43ba-92d3-58d4ced66025 in service fd00:1122:3344:1::1
+ internal_ntp c81c9d4a-36d7-4796-9151-f564d3735152 in service fd00:1122:3344:103::21
+ nexus b2573120-9c91-4ed7-8b4f-a7bfe8dbc807 in service fd00:1122:3344:103::22The new crucible-pantry zone has ID |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much smaller change than the diff stat implies; most of the changes are expectorate outputs because the example system we set up for tests now includes Crucible pantry zones, which shifted a bunch of other zone UUIDs.
Fully supporting Crucible pantry replacement depends on #3763, which I'm continuing to work on. But the reconfigurator side of "start new pantries" is about as trivial as things go and does not depend on #3763, hence this PR.