Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(1/5) [nexus] Add Affinity/Anti-Affinity Groups to API (unimplemented) #7443

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

(1/5) [nexus] Add Affinity/Anti-Affinity Groups to API (unimplemented) #7443

wants to merge 7 commits into from

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jan 30, 2025

Pulled out of #7076

Exposes Affinity/Anti-Affinity Groups in the API, but as unimplemented.

@smklein smklein mentioned this pull request Jan 30, 2025
Open
44 tasks
hawkw
hawkw approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good to me --- more or less precisely what I would expect based on what's specified in RFD 522. Nothing controversial here.

common/src/api/external/mod.rs Show resolved Hide resolved
nexus/external-api/src/lib.rs Outdated Show resolved Hide resolved
david-crespo
david-crespo approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good.

andrewjstone
andrewjstone approved these changes Jan 31, 2025
View reviewed changes
common/src/api/external/mod.rs Outdated Show resolved Hide resolved
nexus/external-api/src/lib.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewjstone andrewjstone andrewjstone approved these changes

@hawkw hawkw hawkw approved these changes

@david-crespo david-crespo david-crespo approved these changes

@karencfv karencfv karencfv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smklein @andrewjstone @hawkw @david-crespo @karencfv