Add SPDX license id and copyright banners to source files needing them

[jafingerhut]

No description provided.

[jafingerhut]

Assuming PR #546 enables the CI checks to pass for this PR in the near future, my intent is that this PR will be preferred over the earlier #543 for two reasons:

• It uses a more automated flow for adding software license information to the files, in particular this new Python program I'm hacking up spdx-check.py [1] analyzes all files in a repo, and generates a Bash script that invokes addlicense [2], which you can then run to add full copyright banners, plus an SPDX license id line, for you (unless that program fails to add one, typically because there is a partial copyright notice already in the file, which requires hand-editing). I'm using the p4runtime repo as a guinea-pig for this couple of scripts, to see if they need enhancements.

• This PR adds Apache copyright banners as well as SPDX license id lines.

[1] https://github.com/jafingerhut/test-spdx-checker
[2] https://github.com/google/addlicense

[jafingerhut]

@chrispsommers @smolkaj I would like to talk about this PR at the next P4Runtime API meeting, in hopes of merging it, or deciding how to change it before it is merged.

[chrispsommers]

@chrispsommers @smolkaj I would like to talk about this PR at the next P4Runtime API meeting, in hopes of merging it, or deciding how to change it before it is merged.

For sure, it'll be on the agenda. Thanks!

[chrispsommers]

From addlicense:

The program ensures source code files have copyright license headers by scanning directory patterns recursively.
It modifies all source files in place and avoids adding a license header to any file that already has one.

So why are your scripts required, why can't addlicense be called directly?

[jafingerhut]

From addlicense:

The program ensures source code files have copyright license headers by scanning directory patterns recursively.
It modifies all source files in place and avoids adding a license header to any file that already has one.

So why are your scripts required, why can't addlicense be called directly?

My spdx-check.py script is not required. You can call addlicense directly if you wish.

In a repo with 50 files that already have SPDX-License-Identifier lines, and 200 that do not, where you want to put a reasonable copyright author and year that differs across those 200 files, writing all of the addlicense commands with those different authors/years can be very tedious. spdx-check.py can create a Bash script with those different addlicense invocations, independent for each source file, for you.

Also, addlicense will not tell you if a file has a copyright notice, but lacks an SPDX-License-Identifier line, as far as I know. My spdx-check.py program will.

[chrispsommers]

Got it, I didn't realize you needed arguments to addlicense. Your script seems very helpful!

[jafingerhut]

Copying this comment from Steffen, accidentally added to a different PR:

Question for Linux foundation from the P4 API WG discussion:

What is their recommendation on who to attribute the license to? Should we use individual authors or a group ("The P4Runtime authors")? Should we have a CONTRIBUTORS file?