This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
rename packet_* to metal_* and rename provider to equinix/terraform-provider-equinix-metal #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Karasek <[email protected]>
displague
force-pushed
the
equinix-metal
branch
from
November 16, 2020 13:27
1aede40
to
810c0d8
Compare
This was referenced Nov 16, 2020
This PR is ready and the tests are passing (as well as can be expected with jitter). I'll be meeting early next week to discuss any logistical issues with the new repository scheme. Barring any complications, this should be ready to merge and migrate after that meeting. |
I'm getting some boxes checked on this rename. With the US holidays this week, this will not land any sooner than 2020-11-30. |
Signed-off-by: Tomas Karasek <[email protected]>
Update versions of github actions containers to address CVE-2020-15228
bump packngo to v0.5.1
Signed-off-by: Cole Helbling <[email protected]>
Signed-off-by: Cole Helbling <[email protected]>
Signed-off-by: Cole Helbling <[email protected]>
resource_packet_spot_market_request: impl missing parameters
Signed-off-by: Tomas Karasek <[email protected]>
Signed-off-by: Tomas Karasek <[email protected]>
Signed-off-by: Tomas Karasek <[email protected]>
…ource docs Signed-off-by: Tomas Karasek <[email protected]>
…s_id Signed-off-by: Tomas Karasek <[email protected]>
Signed-off-by: Tomas Karasek <[email protected]>
Better handling of hardware reservation ID in the device resource
Signed-off-by: Tomas Karasek <[email protected]>
Changelog entry for v3.2.0
Signed-off-by: Tomas Karasek <[email protected]>
…rovider-equinix-metal Renames packethost/terraform-provider-packet to equinix/terraform-provider-equinix-metal The provider resources have been renamed from "packet_*" to "metal_*" This will be treated as a new provider. Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
displague
force-pushed
the
equinix-metal
branch
from
December 6, 2020 22:54
810c0d8
to
5d00a1f
Compare
displague
changed the title
[DO NOT MERGE] rename packet_* to metal_* and rename provider to equinix/terraform-provider-equinix-metal
rename packet_* to metal_* and rename provider to equinix/terraform-provider-equinix-metal
Dec 7, 2020
This was referenced Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default branch for the Packet provider is
master
.This PR will apply to a new default branch,
main
, which will be used as a new Equinix Metal provider atequinix/terraform-provider-equinix-metal
.See https://github.blog/changelog/2020-08-26-set-the-default-branch-for-newly-created-repositories/ for more on the
master
andmain
branch names.This repository will be moved to
equinix/terraform-provider-equinix-metal
and will then be forked back topackethost/terraform-provider-packet
. Thepackethost/terraform-provider-packet
fork should continue to feed into the TF Registry listing for Packet https://registry.terraform.io/providers/packethost/packet/latest (at the existingv3.1.0
), a new registry listing will be created forequinix/terraform-provider-equinix-metal
at https://registry.terraform.io/namespaces/equinix, this will bev4.0.0
.The
main
branch will be removed from thepackethost
repo, andmaster
will be made the default on packethost (as it is now). This will allow for the Packethost provider to continue working while avoiding the confusion that would come from having two branches that represent different providers.The
master
branch on packethost will receive additional commits to introduce deprecation notices.Migration notes will reside in the Equinix Metal README.md.
The
packet_
resources have all been renamed tometal_
.Users will face challenges in migrating to this new provider. It should be possible by doing the following:
packet_
references in the module tometal_
terraform init --upgrade
to fetch the equinix-metal providerThese changes were made mechanically with an order and search filters that prevented renaming things that did not need renaming or should not be renamed.
Fixes #279
Caveat on Issue links
GitHub forwarding will not take users from packethost/t-p-p -> equinix/t-p-e-m, because the packethost fork will reside at packhoet/t-p-p. This will cause external links to GH issues and pull-requests on t-p-p to 404. Older links to terraform-providers/terraform-provider-packet, however, will successfully redirect to equinix/t-p-e-m. Maintaining these issue and PR links is not a primary concern.