Refactor #300
Closed
Refactor #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank1513
commented
Jun 13, 2024
mayank1513
commented
- Refactored for readability and best practices.
- Reduced build size of minified bundle → Might not have much impact on the min-zip size.
- should not be used before defined - Make it clear without getting into temporal vs spatial dead zone
- don't worry it will be minified by the package builder - tsbuild
…browsers without requiring vendor prefixes.
- smaller build size - avoid magic numbers and typos
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Please update the deployment config - set node version to 20 |
|
Should I bump |
|
I don't really see a real benefit in these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.