Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-5629] fix: getAllRoleMappings sdk when both maps are non-null with overlapping keys #532

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Oct 7, 2024

List of Changes

Fix getAllRoleMappings method

Motivation and Context

overlapping keys causes replace of roleMappings productRole association. This PR fix this issue maintain both productRoles list

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner October 7, 2024 14:05
@github-actions github-actions bot added the libs label Oct 7, 2024
@manuraf manuraf changed the title [SELC-5629] fix: when both maps are non-null with overlapping keys [SELC-5629] fix: getAllRoleMappings sdk when both maps are non-null with overlapping keys Oct 7, 2024
@manuraf manuraf requested a review from a team as a code owner October 7, 2024 14:11
@github-actions github-actions bot added the ops label Oct 7, 2024
Copy link

sonarqubecloud bot commented Oct 7, 2024

@manuraf manuraf merged commit 9e7d165 into main Oct 7, 2024
8 checks passed
@manuraf manuraf deleted the bugfix/SELC-5629 branch October 7, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant