feat: Update quoter MINIMUM_VALID_RESPONSE_LENGTH #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chefburger
reviewed
Aug 29, 2024
src/pool-cl/lens/CLQuoter.sol
Outdated
| /// @dev int128[2] includes 32 bytes for offset, 32 bytes for length, and 32 bytes for each element | ||
| /// @dev Plus sqrtPriceX96After padded to 32 bytes and initializedTicksLoaded padded to 32 bytes | ||
| /// MINIMUM_VALID_RESPONSE_LENGTH = 192; | ||
| constructor(address _poolManager) Quoter(_poolManager, 192) { |
There was a problem hiding this comment.
Is it better to make it constant
There was a problem hiding this comment.
it is immutable in Quoter.sol.
share with BIn and CL.
you mean define a constant in both CLQuoter.sol and BINQuoter.sol ?
chefburger
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.