[Part 1 of 3] v4-core dependency + gas snapshot + ci runs tweak (s52) #74
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| src = 'src' | ||
| out = 'foundry-out' | ||
| solc_version = '0.8.26' | ||
| optimizer_runs = 1_000_000 | ||
| via_ir = true | ||
| ffi = true | ||
| gas_limit = "3000000000" | ||
|
|
@@ -15,24 +15,26 @@ fs_permissions = [ | |
| evm_version = 'cancun' | ||
| bytecode_hash = "none" | ||
|
|
||
| additional_compiler_profiles = [ | ||
| { name = "clPosm", optimizer_runs = 9000 } | ||
| ] | ||
|
|
||
| compilation_restrictions = [ | ||
| { paths = "src/pool-cl/CLPositionManager.sol", optimizer_runs = 9000 } | ||
| ] | ||
|
|
||
| [fuzz] | ||
| runs = 5 # change this for higher number of fuzz runs locally | ||
|
There was a problem hiding this comment. set lower fuzz/invariant runs locally, so dev local |
||
|
|
||
| [invariant] | ||
| runs = 5 # change this for higher number of invariant runs locally | ||
| depth = 5 # default is 500: https://github.com/foundry-rs/foundry/pull/7957 | ||
|
|
||
| [profile.ci.invariant] | ||
|
Comment on lines
-29
to
-30
There was a problem hiding this comment. seems like this 2 is already false from foundry https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md |
||
| runs = 100 # The number of calls to make in the invariant tests | ||
|
|
||
| [profile.ci_main.fuzz] | ||
| runs = 1000 | ||
|
There was a problem hiding this comment. lower for now - otherwise ci will fail (timeout) - https://github.com/pancakeswap/pancake-v4-periphery/issues/73 we can visit that issue again if we have time and see whats a suitable number |
||
|
|
||
| [profile.ci_main.invariant] | ||
| runs = 1000 # The number of calls to make in the invariant tests | ||
Submodule pancake-v4-core
updated
from 1b4b44 to 284e45
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| pancake-v4-core/=lib/pancake-v4-core/ | ||
| ds-test/=lib/pancake-v4-core/lib/forge-std/lib/ds-test/src/ | ||
| forge-std/=lib/pancake-v4-core/lib/forge-std/src/ | ||
| openzeppelin-contracts/=lib/pancake-v4-core/lib/openzeppelin-contracts/ | ||
| solmate/=lib/pancake-v4-core/lib/solmate/ | ||
| permit2/=lib/permit2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "mock10commands": "82785" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "testMigrateFromV2IncludingInit": "1176442", | ||
| "testMigrateFromV2WithoutInit": "1046490", | ||
| "testMigrateFromV2WithoutNativeToken": "1087310" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "BinMigratorBytecode size": "15187", | ||
| "testMigrateFromV3IncludingInit": "1248658", | ||
| "testMigrateFromV3WithoutInit": "1118687", | ||
| "testMigrateFromV3WithoutNativeToken": "1153511" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "testMigrateFromV2IncludingInit": "1176442", | ||
| "testMigrateFromV2WithoutInit": "1046490", | ||
| "testMigrateFromV2WithoutNativeToken": "1087310" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "BinMigratorBytecode size": "15187", | ||
| "testMigrateFromV3IncludingInit": "1246640", | ||
| "testMigrateFromV3WithoutInit": "1116669", | ||
| "testMigrateFromV3WithoutNativeToken": "1151493" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "BinPositionManagerBytecode size": "17435" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "test_addLiquidity_OutsideActiveId": "292694", | ||
| "test_addLiquidity_SingleBin": "532073", | ||
| "test_addLiquidity_ThreeBins": "905930", | ||
| "test_decreaseLiquidity_threeBins": "184859", | ||
| "test_decreaseLiquidity_threeBins_half": "203748" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "test_addLiquidity": "847340", | ||
| "test_addLiquidity_excessEth": "849077", | ||
| "test_decreaseLiquidity": "191515" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "BinQuoterBytecode size": "6839" | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
stableas local foundry isstabletoo