Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump technic from 573aa31 to b283cc6 #1962

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 15, 2021

Bumps technic from 573aa31 to b283cc6.

Commits
  • b283cc6 Refactoring, fixing and adding wrench registrations (#242)
  • 5aeeb27 Tests for overload and important internal data
  • 8095dd9 Update solar array nodenames for tests
  • d15f7aa Add tests for custom machine registration
  • 28e0470 Update cable registration
  • 148a858 Update common machine registration API
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [technic](https://github.com/mt-mods/technic) from `573aa31` to `b283cc6`.
- [Release notes](https://github.com/mt-mods/technic/releases)
- [Commits](mt-mods/technic@573aa31...b283cc6)

---
updated-dependencies:
- dependency-name: technic
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 15, 2021
@BuckarooBanzay
Copy link
Contributor

2021-11-15 20:05:12: ERROR[Server]: Node not present and not available in an alias/lbm: wrench:picked_up_technic_alloy_furnace_active
2021-11-15 20:05:12: ERROR[Server]: Node not present and not available in an alias/lbm: wrench:picked_up_technic_grinder_active
2021-11-15 20:05:12: ERROR[Server]: Node not present and not available in an alias/lbm: wrench:picked_up_technic_extractor
2021-11-15 20:05:12: ERROR[Server]: Node not present and not available in an alias/lbm: wrench:picked_up_technic_extractor_active
2021-11-15 20:05:12: ERROR[Server]: Node not present and not available in an alias/lbm: wrench:picked_up_technic_compressor_active
2021-11-15 20:05:12: ERROR[Server]: Node not present and not available in an alias/lbm: wrench:picked_up_technic_compressor
2021-11-15 20:05:12: ERROR[Server]: Node not present and not available in an alias/lbm: wrench:picked_up_technic_grinder
2021-11-15 20:05:12: ERROR[Server]: Node not present and not available in an alias/lbm: wrench:picked_up_technic_alloy_furnace
2021-11-15 20:05:12: ERROR[Server]: Node not present and not available in an alias/lbm: wrench:picked_up_default_sign_wall

@S-S-X
Copy link
Member

S-S-X commented Nov 15, 2021

Well, those seems to be old definition names for things that were registered for wrench... now where do these come from?
It is this anyway: mt-mods/technic#242

(all names are deprecated / defined in legacy.lua...)

edit. I think I just got it, wrench actually registered picked up nodes using whatever legacy name that was originally supplied for it and now those nodes are registered with old names.

Probably have to add aliases for those... did not even think about those items first. For wrench like tool would be actually better to not register new node for each pickup ever.

@S-S-X
Copy link
Member

S-S-X commented Nov 15, 2021

mt-mods/technic#246 but it might not really be worth it, going through this stuff bit better I think it might be that test data should be updated and these nodes removed from list.

Only wrench:picked_up_default_sign_wall might be still relevant but not sure, everything from technic seems to simply be too old to be significant even as alias anymore.

@BuckarooBanzay
Copy link
Contributor

mt-mods/technic#246 but it might not really be worth it, going through this stuff bit better I think it might be that test data should be updated and these nodes removed from list.

I'm copying the new items-list after this is merged then (i'm not going to edit this monstrosity manually: https://github.com/pandorabox-io/pandorabox_integration_test/blob/master/nodenames.dat)

@OgelGames OgelGames added the PR/WIP Upgrade contents are a work-in-progress label Nov 16, 2021
@S-S-X S-S-X removed the PR/WIP Upgrade contents are a work-in-progress label Nov 16, 2021
@S-S-X
Copy link
Member

S-S-X commented Nov 16, 2021

Dropped PR/WIP label as I've closed PR that affected these aliases.
All these aliases and nodes are unneeded and should be removed from test data.

See linked issues / pull requests for more info but basically fix test data and other than that it should be all fine.

@OgelGames
Copy link
Contributor

OgelGames commented Nov 17, 2021

I added that label because there will be more changes that will remove the nodes added in the latest commit, not because of the alias PR.

Now that I think of it, I should just close this PR.

@OgelGames OgelGames closed this Nov 17, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 17, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/submodules/technic-b283cc6 branch November 17, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants