Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vite.config should be only included on tsconfig.node #405

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

alicanerdurmaz
Copy link
Contributor

We get build error when "vite.config.ts" is included in tsconfig.json:

npm run build

> [email protected] build
> tsc && refine build

error TS6305: Output file '/Users/alicanerdurmaz/Desktop/vite-test/vite.config.d.ts' has not been built from source file '/Users/alicanerdurmaz/Desktop/vite-test/vite.config.ts'.
  The file is in the program because:
    Matched by include pattern 'vite.config.ts' in '/Users/alicanerdurmaz/Desktop/vite-test/tsconfig.json'

  tsconfig.json:19:22
    19   "include": ["src", "vite.config.ts"],
                            ~~~~~~~~~~~~~~~~
    File is matched by include pattern specified here.

according the vite's default settings, "vite.config.ts" should be only included on tsconfig.node.json

Copy link

cypress bot commented Jul 2, 2024

5 failed tests on run #8870 ↗︎

5 68 0 0 Flakiness 0

Details:

fix: vite.config should be only included on tsconfig.node (#405)
Project: Superplate Core Plugins Commit: c179ea7af7
Status: Failed Duration: 16:27 💡
Started: Jul 16, 2024 8:12 AM Ended: Jul 16, 2024 8:28 AM
Failed  cypress/e2e/build-test.cy.js • 1 failed test • e2e-local-nextjs-strapi-v4-tailwindcss-strapi

View Output Video

Test Artifacts
build test > should build Screenshots Video
Failed  cypress/e2e/build-test.cy.js • 1 failed test • e2e-local-nextjs-strapi-v4-no-strapi

View Output Video

Test Artifacts
build test > should build Screenshots Video
Failed  cypress/e2e/build-test.cy.js • 1 failed test • e2e-local-vite-custom-json-rest-tailwindcss-keycloak

View Output Video

Test Artifacts
build test > should build Screenshots Video
Failed  cypress/e2e/build-test.cy.js • 1 failed test • e2e-local-vite-hasura-mui-keycloak

View Output Video

Test Artifacts
build test > should build Screenshots Video
Failed  cypress/e2e/build-test.cy.js • 1 failed test • e2e-local-vite-hasura-antd-keycloak

View Output Video

Test Artifacts
build test > should build Screenshots Video

Review all test suite changes for PR #405 ↗︎

@BatuhanW BatuhanW merged commit c179ea7 into master Jul 16, 2024
169 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants