Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanups #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some cleanups #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
382113e
!!depth.texture is always true here
myurasov Nov 23, 2015
abe0e37
Remove meaningful line
myurasov Nov 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/scripts/classes/DepthyViewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,15 +469,14 @@ Copyright (c) 2014 Rafał Lindemann. http://panrafal.github.com/depthy
depthTextureSprite = new PIXI.Sprite(depth.texture);
depthTextureSprite.filters = [depthBlurFilter];
depthTextureSprite.scale = new PIXI.Point(scale, scale);
depthTextureSprite.renderable = !!depth.texture;
depthTextureSprite.renderable = true;

depthTextureSprite.anchor = {x: 0.5, y: 0.5};
depthTextureSprite.position = {x: stageSize.width / 2, y: stageSize.height / 2};

if (depth.useAlpha) {
// move inverted alpha to rgb, set alpha to 1
depthTextureSprite.filters.push(invertedAlphaToRGBFilter);
depthTextureSprite.filters = depthTextureSprite.filters;
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIR it was set on purpose, are you sure it works correctly now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, seems to work just fine. :)

On Tue, Nov 24, 2015 at 3:53 AM, Rafał Lindemann [email protected]
wrote:

In app/scripts/classes/DepthyViewer.js
#31 (comment):

@@ -477,7 +477,6 @@ Copyright (c) 2014 Rafał Lindemann. http://panrafal.github.com/depthy
if (depth.useAlpha) {
// move inverted alpha to rgb, set alpha to 1
depthTextureSprite.filters.push(invertedAlphaToRGBFilter);

  •      depthTextureSprite.filters = depthTextureSprite.filters;

AFAIR it was set on purpose, are you sure it works correctly now?

—
Reply to this email directly or view it on GitHub
https://github.com/panrafal/depthy/pull/31/files#r45725779.

Mikhail Yurasov

depthTextureContainer.addChild(depthTextureSprite);
} else {
Expand Down