Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of requires #92

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Reduce number of requires #92

wants to merge 4 commits into from
+24 −48

Conversation

sethherr
Copy link
Contributor

No description provided.

lmarburger
lmarburger reviewed Jul 11, 2017
View reviewed changes
Copy link
Contributor

@lmarburger lmarburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a ruby file uses a library, I'm all for having it explicitly require it. Otherwise, that file can only run by using an opaque loading mechanism where the libs required globally are known.

Rakefile
@@ -1,6 +1,7 @@
require 'rubygems'
require 'rake'
require 'date'
require File.expand_path('../lib/papertrail/version', __FILE__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/ should be in the path when this is run so "papertrail/version" should be all that's necessary to require.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Doesn't work 😢

@sethherr
Copy link
Contributor Author

@lmarburger I waffled on what made more sense with requiring papertrail, and your comment makes me think maybe I chose the wrong course. Would it be better to put the require papertrail in each of the cli ruby files rather than the bin files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmarburger lmarburger lmarburger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethherr @lmarburger