chore: Automatic UserMappingOptions methods implementation #41
Conversation
evanxg852000
requested review from
rebasedming and
philippemnoel
as code owners
evanxg852000
requested review from
neilyio
and removed request for
philippemnoel
|
I’m uncertain if adding new dependencies just to time this refactoring is justified. |
|
@Weijun-H 👍🏾 Indeed this was also my concern given it's currently used in one place. However, I discussed this with a team member. It was deemed ok since it's lightweight. It would be perfectly valid if the consensus is to put this aside for now to avoid further dependencies. It's not a critical change anyway. |
How about merging this PR first and then splitting the refactoring task into multiple "good first issue" tasks? |
That sounds great. Could you please help open up the issues and link them in the PR here? Then we can merge the PR |
file a ticket #80 to track |
rebasedming
force-pushed
the
strum-for-better-emums
branch
from
953d8b4 to
269172f
Compare
* added strum to automatically provide as_ref & iter methods to enums * convert to strum --------- Co-authored-by: Ming Ying <[email protected]>
* added strum to automatically provide as_ref & iter methods to enums * convert to strum --------- Co-authored-by: Ming Ying <[email protected]>
Ticket(s) Closed
DeltaOptionby using strum #82IcebergOptionby using strum #83ParquetOptionby using strum #84What
Added a dependency on strum create to automatically provide
as_ref&itermethods to enums. More can be added if needed.Why
The strum can be used to remove useful manual implementations
How
Tests
Made sure the
as_ref&itermethods provide the expected output.