Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: more FxHashMaps for SenderId key #13188

Merged
merged 1 commit into from
Dec 6, 2024
Merged

perf: more FxHashMaps for SenderId key #13188

merged 1 commit into from
Dec 6, 2024

Conversation

hai-rise
Copy link
Contributor

@hai-rise hai-rise commented Dec 6, 2024

Small optimization for TxPool::on_canonical_state_change and related HashMaps with SenderId as key.

@hai-rise hai-rise requested a review from mattsse as a code owner December 6, 2024 18:43
mattsse
mattsse approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely remember doing this, maybe somewhere else or some other fields.

ty!

EDIT: ah yeah we did this for some other pool maps

@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-tx-pool Related to the transaction mempool labels Dec 6, 2024
@mattsse mattsse added this pull request to the merge queue Dec 6, 2024
Merged via the queue into paradigmxyz:main with commit a0326e4 Dec 6, 2024
42 checks passed
@hai-rise hai-rise deleted the fxhashmap-senderid branch December 7, 2024 01:33
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
@hai-rise @lean-apple
perf: more FxHashMaps for SenderId key (paradigmxyz#13188)
cedf7d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hai-rise @mattsse