fix: blockchain-provider-state-retrieva-issue #13817
Open
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhanraj30
requested review from
rakita,
joshieDo and
shekhirin
as code owners
mattsse
reviewed
Jan 16, 2025
Comment on lines
+560
to
+566
| } else if let Some(pending_state) = self.canonical_in_memory_state.pending_state() { | ||
| // Check if the pending state matches the requested hash | ||
| if pending_state.hash() == hash { | ||
| Ok(Box::new(self.block_state_provider(&pending_state)?)) | ||
| } else { | ||
| Err(ProviderError::StateForHashNotFound(hash)) | ||
| } |
There was a problem hiding this comment.
how is this different than
fn pending_state_by_hash(&self, block_hash: B256) -> ProviderResult<Option<StateProviderBox>> {
if let Some(pending) = self.canonical_in_memory_state.pending_state() {
if pending.hash() == block_hash {
return Ok(Some(Box::new(self.block_state_provider(&pending)?)));
}
}
Ok(None)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue details: #13794
This modification ensures that the function first checks for the pending state within the canonical_in_memory_state if the previous checks fail.