feat: add WithdrawalsProvider::withdrawals_by_block_range
#13877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-enhancement
joshieDo
commented
Jan 20, 2025
mattsse
reviewed
Jan 20, 2025
Comment on lines
16
to
20
| /// Returns the withdrawals per block within the requested block range. | ||
| fn withdrawals_by_block_range( | ||
| &self, | ||
| range: RangeInclusive<BlockNumber>, | ||
| ) -> ProviderResult<Vec<Withdrawals>>; |
There was a problem hiding this comment.
is return vec here problematic for pre withdrawals blocks?
joshieDo
force-pushed
the
joshie/withdrawalsrange
branch
from
17dee72 to
4cfdb9b
Compare
joshieDo
force-pushed
the
joshie/withdrawalsrange
branch
from
4cfdb9b to
a8f9e52
Compare
joshieDo
force-pushed
the
joshie/withdrawalsrange
branch
from
a8f9e52 to
980e4ad
Compare
joshieDo
force-pushed
the
joshie/withdrawalsrange
branch
from
980e4ad to
6e86a4f
Compare
joshieDo
requested review from
Rjected,
fgimenez,
onbjerg and
gakonst
as code owners
joshieDo
force-pushed
the
joshie/withdrawalsrange
branch
2 times, most recently
from
e0a84a4 to
26394df
Compare
mattsse
approved these changes
Jan 21, 2025
Comment on lines
169
to
170
| for ((header, transactions), withdrawals) in | ||
| inputs.into_iter().zip(provider.withdrawals_by_block_range(block_range)?) |
There was a problem hiding this comment.
ah nice, now we no longer need the shanghai check
joshieDo
force-pushed
the
joshie/withdrawalsrange
branch
from
26394df to
7f32447
Compare
mattsse
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using it on
read_block_bodieswith the provider, and not rely solely on DB cursorsfor
StaticFileSegment::BlockMetaon top of #13894