chore: make transaction type fields private #13915
Open
+92
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencartavia
requested review from
mattsse,
rakita,
joshieDo,
shekhirin,
onbjerg,
rkrasiuk,
Rjected and
gakonst
as code owners
mattsse
requested changes
Jan 22, 2025
Comment on lines
+41
to
+42
| let transaction_signed = Self::new(transaction, signature, hash); | ||
| Ok(transaction_signed) |
There was a problem hiding this comment.
this didn't require a change
Comment on lines
+676
to
+678
| TransactionSigned::new_unhashed( | ||
| tx.transaction().clone(), | ||
| *tx.signature(), |
There was a problem hiding this comment.
this looks odd, why does this require a conversion at all,
in any case we need decomposition fns like
reth/crates/primitives-traits/src/block/mod.rs
Lines 99 to 100 in cd44fc3
| @@ -913,7 +913,7 @@ impl TryFrom<Recovered<TransactionSigned>> for MockTransaction { | |||
| let size = transaction.size(); | |||
|
|
|||
| #[allow(unreachable_patterns)] | |||
| match transaction.transaction { | |||
| match transaction.transaction() { | |||
There was a problem hiding this comment.
we also want fn into_transaction then these changes aren't necessary
There was a problem hiding this comment.
so should I change this one
pub const fn transaction(&self) -> &Transaction {
&self.transaction
}
with this one?
pub fn into_transaction(self) -> Transaction {
self.transaction
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #13913