[wip] feat: alloy tx type conversions back to OpTransactionSigned #14121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
A-op-reth
emhane
reviewed
Jan 31, 2025
mattsse
requested changes
Jan 31, 2025
Comment on lines
34
to
45
| macro_rules! impl_from_signed { | ||
| ($($tx:ident),*) => { | ||
| $( | ||
| impl From<Signed<$tx>> for OpTransactionSigned { | ||
| fn from(value: Signed<$tx>) -> Self { | ||
| let(tx,sig,hash) = value.into_parts(); | ||
| Self::new(tx.into(), sig, hash) | ||
| } | ||
| } | ||
| )* | ||
| }; | ||
| } |
There was a problem hiding this comment.
I want this below the struct def and impl
| let (tx, hash) = tx.into_parts(); | ||
| Self::new(OpTypedTransaction::Deposit(tx), TxDeposit::signature(), hash) | ||
| } | ||
| _ => panic!("Invalid OpTxEnvelope variant"), |
There was a problem hiding this comment.
Comment on lines
169
to
171
| let (tx, hash) = tx.into_parts(); | ||
| Self::new(OpTypedTransaction::Deposit(tx), TxDeposit::signature(), hash) | ||
| } |
There was a problem hiding this comment.
for this we can add a from Sealed<TxDeposit> impl
Comment on lines
608
to
610
| let hash = if is_deposit(&transaction) { B256::ZERO } else { signature_hash(&transaction) }; | ||
|
|
||
| Ok(Self::new(transaction, signature)) | ||
| Ok(Self::new(transaction, signature, hash)) |
There was a problem hiding this comment.
this should use new_unhashed instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should close #13914