Use v1.0.0 release of trusted services #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last commit is only for testing the cross-compiler image on the CI. Will be dropped once the CI is green. |
|
Manual CI run for testing new docker images: |
tgonzalezorlandoarm
requested changes
May 10, 2024
anta5010
reviewed
May 10, 2024
gowthamsk-arm
force-pushed
the
trusted_services
branch
from
c8117dd to
e544869
Compare
Builds and uses 1.0.0 version of trusted services in docker files. Further commits updates the provider in parsec to use the new RPC APIs. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The newer version of trusted services repo also includes the encoding scheme in the service name to locate the service. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
gowthamsk-arm
force-pushed
the
trusted_services
branch
from
e544869 to
c3b429e
Compare
|
CI run with new docker images: https://github.com/parallaxsecond/parsec/actions/runs/9031610348 |
gowthamsk-arm
force-pushed
the
trusted_services
branch
from
c3b429e to
23270f9
Compare
|
CI run with new docker images: https://github.com/parallaxsecond/parsec/actions/runs/9033081394 |
ionut-arm
previously approved these changes
May 10, 2024
| @@ -120,7 +120,7 @@ run_old_e2e_tests() { | |||
| run_key_mappings_tests() { | |||
| # There is no keys generated for CryptoAuthLib yet. | |||
There was a problem hiding this comment.
Could you also add info about the TS provider in the comment?
There was a problem hiding this comment.
Yes will add a comment for it.
The new libts library doesnt produce keys in the form of 00*.psa_its so disable the tests in the CI for it. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The 1.0.0 version of trusted services has RPC APIs changed. This patch configures the provider to use the newer ones and updates the submodule. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The new trusted services RPC calls come from rpc_caller_session.h. Include this while generating bindings using bindgen. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
Signed-off-by: Gowtham Suresh Kumar <[email protected]>
gowthamsk-arm
force-pushed
the
trusted_services
branch
from
23270f9 to
4161618
Compare
tgonzalezorlandoarm
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes the following changes:
Signed-off-by: Gowtham Suresh Kumar [email protected]