Multi-Asset and Cross-Chain Bounties #6189
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidk-pt
added
the
T1-FRAME
muharem
commented
Nov 14, 2024
muharem
commented
Nov 14, 2024
muharem
commented
Nov 14, 2024
muharem
commented
Nov 14, 2024
| ensure!( | ||
| bounty.value <= max_amount, | ||
| native_amount <= max_amount, |
There was a problem hiding this comment.
this will needs to be wrapped into the context. check the treasury spend call for reference
muharem
commented
Nov 15, 2024
| ) | ||
| .map_err(|_| Error::<T, I>::FundingError)?; | ||
| *payment_status = PaymentState::Attempted { id }; | ||
| return Ok(Pays::No.into()); |
There was a problem hiding this comment.
the caller should still pay. but you sill needs DispatchResultWithPostInfo type because this call in most cases will have bigger worth case weight than actual. the payout have two payments to process, the funding and the cancelation only one. I would process all of them with the same calls, process_payment and check_payment_status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #5500
Introduces the
asset_kindparameter for a bounty and moves the payments processing from theCurrency(only local transfers) trait toPay(simpler alternative allowing cross-chain setups) trait.