[pallet-revive] use evm decimals in call host fn

[pgherveou]

This PR update the pallet to use the EVM 18 decimal balance in contracts call and host functions instead of the native balance.

It also updates the js example to add the piggy-bank solidity contract that expose the problem

[pgherveou]

/cmd prdoc --audience runtime_dev --bump minor

[jarkkojs]

My expertise is limited but with that I don't see anything obnoxious...

[athei]

Didn't we do the conversion inside the checked extrinsic conversion before? I would expect that code to be touched here, too.

[athei]

Are those versioned by accident? Same for the other build outputs.

[pgherveou]

What do you mean by versioned?

[athei]

Meaning: Why are we checking in compilation outputs?

[pgherveou]

They are used to run tests e.g https://github.com/paritytech/polkadot-sdk/blob/pg/piggy-bank/substrate/frame/revive/rpc/src/tests.rs?plain=1#L243-L260

they were already checked in, except they were part of the json file, this approach works better for tooling like chaintypes that generates the ts types from the abi files

[athei]

So if we make breaking changes to pallet_revive we need to wait for a new revive version and then rebuild those files? Because there are CI tests that use them?

[pgherveou]

Are you suggesting, that we only build test cases in Rust?
Would be pretty bad if we were breaking people's tooling and they could not submit a contract on chain anymore ?

[pgherveou]

Didn't we do the conversion inside the checked extrinsic conversion before? I would expect that code to be touched here, too.

right fixed by using the helper functions d4364fd

and the rpc does not have to know about this 0bd3f74

[xermicus]

Can those not be vendored?

[pgherveou]

what do you mean exactly, there is a js build script that can regenerate these blobs

substrate/frame/revive/rpc/examples/js/src/build-contracts.ts

[athei]

Then we shouldn't put them in git?

[pgherveou]

well they are mostly here to play with js code
but I also use them to run integration tests rpc tests in CI
I don't want to add the revive tooling to the mono repo

[xermicus]

Ok no hard opinion, I just find vendored code blobs always annoying because they have to get updated manually (in this case with breaking PVM or pallet changes

[smiasojed]

Do we have information about native and EVM balances, as well as their conversion, in our tutorial? I assume that when we use the Substrate tools, we will see the native balance, and when we use the Ethereum tools, we will see the EVM balance.

[pgherveou]

Do we have information about native and EVM balances, as well as their conversion, in our tutorial? I assume that when we use the Substrate tools, we will see the native balance, and when we use the Ethereum tools, we will see the EVM balance.

good call, so these number should be the same.
i.e when you look at the balance in your MM it should be the same as the balance for the same account in subxt
so it should be transparent from the point of view of the user.
One thing that should be mentioned though is that you can't transact with values that are too small for Substrate since the min value is 1_000_000wei (1Mwei)

[smiasojed]

Just to confirm, I can use the pallet-balances to check the account balance, or I can look into the block explorer. Will it match what I see in MetaMask?

[pgherveou]

Just to confirm, I can use the pallet-balances to check the account balance, or I can look into the block explorer. Will it match what I see in MetaMask?

All ui should display the same value
but if you look at the actual value with pjs you have to divide the EVM value by 1_000_000 since EVM use 18 digits and we use 12

[github-actions]

Review required! Latest push from author must always be reviewed