Return compiler crash in HTTP response #15
Merged
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xermicus
approved these changes
Nov 15, 2024
| case 'SIGABRT': | ||
| case null: | ||
| // The revive compiler crash | ||
| return done(null, this.generateCompilerError(stderr)); |
There was a problem hiding this comment.
Though I assume stderr should be sufficient
There was a problem hiding this comment.
panic!, assert! goes to stderr, what case do you mean?
There was a problem hiding this comment.
Mainly LLVM assertions, but I just checked they are written to stderr too so we should be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes paritytech/contract-issues#8
Return compiler crash in HTTP response