fix: Incorrectly attempting to send body in GET, DELETE requests (#…

…169)
parse-community · Feb 8, 2025 · 7ca2681 · 7ca2681
1 parent 0999242
commit 7ca2681
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -44,6 +44,8 @@ jobs:
         with:
           fail_ci_if_error: true
           token: ${{ secrets.CODECOV_TOKEN }}
+        env:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
diff --git a/lib/client.js b/lib/client.js
@@ -567,7 +567,7 @@ module.exports = function (dependencies) {
       responseData += data;
     });
 
-    if (Object.keys(notification.body).length > 0) {
+    if (notification.body !== '{}') {
       request.write(notification.body);
     }
 

diff --git a/test/client.js b/test/client.js
@@ -1761,7 +1761,7 @@ describe('ManageChannelsClient', () => {
       const mockHeaders = { 'apns-channel-id': channel, ...additionalHeaderInfo };
       const mockNotification = {
         headers: mockHeaders,
-        body: {},
+        body: '{}',
       };
       const bundleId = BUNDLE_ID;
       const result = await client.write(mockNotification, bundleId, 'channels', 'delete');
@@ -1822,7 +1822,7 @@ describe('ManageChannelsClient', () => {
       const mockHeaders = { 'apns-request-id': requestId };
       const mockNotification = {
         headers: mockHeaders,
-        body: {},
+        body: '{}',
       };
       const bundleId = BUNDLE_ID;
       const result = await client.write(mockNotification, bundleId, 'allChannels', 'get');

diff --git a/test/notification/index.js b/test/notification/index.js
@@ -17,6 +17,11 @@ describe('Notification', function () {
       expect(note.topic).to.equal('io.apn.node');
       expect(compiledOutput()).to.have.nested.deep.property('aps.badge', 5);
     });
+
+    it('no initialization values', function () {
+      expect(note.compile()).to.equal('{}');
+      expect(compiledOutput()).to.be.empty;
+    });
   });
 
   describe('rawPayload', function () {