Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - [Linux] Fix keyboard grab when running on Wayland #158

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from

Conversation

Namaneo
Copy link

@Namaneo Namaneo commented Jan 23, 2025

This PR sets a few Gnome properties to allow keyboard grabbing on Wayland. This notably fixes Ubuntu 24.04, and probably all Gnome-based distributions that use Wayland.

The properties we need to change can be retrieved with the following terminal commands:

gsettings get org.gnome.mutter.wayland xwayland-allow-grabs
gsettings get org.gnome.mutter.wayland xwayland-grab-access-rules

If not altered by anything else, those commands should respectively return false and [] (else you can reset them instead of get). After starting the application, those values should now respectively be true and ['parsecd'], and keyboard should correctly be grabbed when requested.

@Namaneo Namaneo added the 2. Review requested You have coded your code, and can now be reviewed. label Jan 23, 2025
@Namaneo Namaneo self-assigned this Jan 23, 2025
@Kodikuu
Copy link

Kodikuu commented Feb 3, 2025

  1. If a user has already set xwayland-grab-access-rules for something else, does this overwrite it?
    • Consider doing a get and appending if parsecd is not present, if possible
  2. How does this behave on X11?

@Namaneo Namaneo removed the 2. Review requested You have coded your code, and can now be reviewed. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants