Skip to content

Commit

Permalink
Merge pull request rook#13913 from travisn/reef-18.2.2
Browse files Browse the repository at this point in the history
core: Set default ceph version to v18.2.2
  • Loading branch information
travisn authored Mar 12, 2024
2 parents b6b5628 + 026d745 commit a67d742
Show file tree
Hide file tree
Showing 18 changed files with 36 additions and 36 deletions.
12 changes: 6 additions & 6 deletions Documentation/CRDs/Cluster/ceph-cluster-crd.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Settings can be specified at the global level to apply to the cluster as a whole
* `external`:
* `enable`: if `true`, the cluster will not be managed by Rook but via an external entity. This mode is intended to connect to an existing cluster. In this case, Rook will only consume the external cluster. However, Rook will be able to deploy various daemons in Kubernetes such as object gateways, mds and nfs if an image is provided and will refuse otherwise. If this setting is enabled **all** the other options will be ignored except `cephVersion.image` and `dataDirHostPath`. See [external cluster configuration](external-cluster.md). If `cephVersion.image` is left blank, Rook will refuse the creation of extra CRs like object, file and nfs.
* `cephVersion`: The version information for launching the ceph daemons.
* `image`: The image used for running the ceph daemons. For example, `quay.io/ceph/ceph:v18.2.1`. For more details read the [container images section](#ceph-container-images).
* `image`: The image used for running the ceph daemons. For example, `quay.io/ceph/ceph:v18.2.2`. For more details read the [container images section](#ceph-container-images).
For the latest ceph images, see the [Ceph DockerHub](https://hub.docker.com/r/ceph/ceph/tags/).
To ensure a consistent version of the image is running across all nodes in the cluster, it is recommended to use a very specific image version.
Tags also exist that would give the latest version, but they are only recommended for test environments. For example, the tag `v17` will be updated each time a new Quincy build is released.
Expand Down Expand Up @@ -110,8 +110,8 @@ These are general purpose Ceph container with all necessary daemons and dependen
| -------------------- | --------------------------------------------------------- |
| vRELNUM | Latest release in this series (e.g., *v17* = Quincy) |
| vRELNUM.Y | Latest stable release in this stable series (e.g., v17.2) |
| vRELNUM.Y.Z | A specific release (e.g., v18.2.1) |
| vRELNUM.Y.Z-YYYYMMDD | A specific build (e.g., v18.2.1-20240103) |
| vRELNUM.Y.Z | A specific release (e.g., v18.2.2) |
| vRELNUM.Y.Z-YYYYMMDD | A specific build (e.g., v18.2.2-20240311) |

A specific will contain a specific release of Ceph as well as security fixes from the Operating System.

Expand Down Expand Up @@ -414,7 +414,7 @@ metadata:
namespace: rook-ceph
spec:
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
dataDirHostPath: /var/lib/rook
mon:
count: 3
Expand Down Expand Up @@ -517,7 +517,7 @@ metadata:
namespace: rook-ceph
spec:
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
dataDirHostPath: /var/lib/rook
mon:
count: 3
Expand Down Expand Up @@ -645,7 +645,7 @@ kubectl -n rook-ceph get CephCluster -o yaml
deviceClasses:
- name: hdd
version:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
version: 16.2.6-0
conditions:
- lastHeartbeatTime: "2021-03-02T21:22:11Z"
Expand Down
6 changes: 3 additions & 3 deletions Documentation/CRDs/Cluster/host-cluster.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ metadata:
spec:
cephVersion:
# see the "Cluster Settings" section below for more details on which image of ceph to run
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
dataDirHostPath: /var/lib/rook
mon:
count: 3
Expand All @@ -49,7 +49,7 @@ metadata:
namespace: rook-ceph
spec:
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
dataDirHostPath: /var/lib/rook
mon:
count: 3
Expand Down Expand Up @@ -101,7 +101,7 @@ metadata:
namespace: rook-ceph
spec:
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
dataDirHostPath: /var/lib/rook
mon:
count: 3
Expand Down
6 changes: 3 additions & 3 deletions Documentation/CRDs/Cluster/pvc-cluster.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ metadata:
namespace: rook-ceph
spec:
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
dataDirHostPath: /var/lib/rook
mon:
count: 3
Expand Down Expand Up @@ -72,7 +72,7 @@ spec:
requests:
storage: 10Gi
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
allowUnsupported: false
dashboard:
enabled: true
Expand Down Expand Up @@ -128,7 +128,7 @@ metadata:
namespace: rook-ceph
spec:
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
dataDirHostPath: /var/lib/rook
mon:
count: 3
Expand Down
2 changes: 1 addition & 1 deletion Documentation/CRDs/Cluster/stretch-cluster.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ spec:
- name: b
- name: c
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
allowUnsupported: true
# Either storageClassDeviceSets or the storage section can be specified for creating OSDs.
# This example uses all devices for simplicity.
Expand Down
10 changes: 5 additions & 5 deletions Documentation/Upgrade/ceph-upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Official Ceph container images can be found on [Quay](https://quay.io/repository

These images are tagged in a few ways:

* The most explicit form of tags are full-ceph-version-and-build tags (e.g., `v18.2.1-20240103`).
* The most explicit form of tags are full-ceph-version-and-build tags (e.g., `v18.2.2-20240311`).
These tags are recommended for production clusters, as there is no possibility for the cluster to
be heterogeneous with respect to the version of Ceph running in containers.
* Ceph major version tags (e.g., `v18`) are useful for development and test clusters so that the
Expand All @@ -67,7 +67,7 @@ CephCluster CRD (`spec.cephVersion.image`).

```console
ROOK_CLUSTER_NAMESPACE=rook-ceph
NEW_CEPH_IMAGE='quay.io/ceph/ceph:v18.2.1-20240103'
NEW_CEPH_IMAGE='quay.io/ceph/ceph:v18.2.2-20240311'
kubectl -n $ROOK_CLUSTER_NAMESPACE patch CephCluster $ROOK_CLUSTER_NAMESPACE --type=merge -p "{\"spec\": {\"cephVersion\": {\"image\": \"$NEW_CEPH_IMAGE\"}}}"
```

Expand All @@ -79,7 +79,7 @@ employed by the new Rook operator release. Employing an outdated Ceph version wi
in unexpected behaviour.

```console
kubectl -n rook-ceph set image deploy/rook-ceph-tools rook-ceph-tools=quay.io/ceph/ceph:v18.2.1-20240103
kubectl -n rook-ceph set image deploy/rook-ceph-tools rook-ceph-tools=quay.io/ceph/ceph:v18.2.2-20240311
```

#### **3. Wait for the pod updates**
Expand All @@ -97,9 +97,9 @@ Confirm the upgrade is completed when the versions are all on the desired Ceph v
kubectl -n $ROOK_CLUSTER_NAMESPACE get deployment -l rook_cluster=$ROOK_CLUSTER_NAMESPACE -o jsonpath='{range .items[*]}{"ceph-version="}{.metadata.labels.ceph-version}{"\n"}{end}' | sort | uniq
This cluster is not yet finished:
ceph-version=v17.2.7-0
ceph-version=v18.2.1-0
ceph-version=v18.2.2-0
This cluster is finished:
ceph-version=v18.2.1-0
ceph-version=v18.2.2-0
```

#### **4. Verify cluster health**
Expand Down
6 changes: 3 additions & 3 deletions deploy/charts/rook-ceph-cluster/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ toolbox:
# -- Enable Ceph debugging pod deployment. See [toolbox](../Troubleshooting/ceph-toolbox.md)
enabled: false
# -- Toolbox image, defaults to the image used by the Ceph cluster
image: #quay.io/ceph/ceph:v18.2.1
image: #quay.io/ceph/ceph:v18.2.2
# -- Toolbox tolerations
tolerations: []
# -- Toolbox affinity
Expand Down Expand Up @@ -92,9 +92,9 @@ cephClusterSpec:
# v17 is Quincy, v18 is Reef.
# RECOMMENDATION: In production, use a specific version tag instead of the general v18 flag, which pulls the latest release and could result in different
# versions running within the cluster. See tags available at https://hub.docker.com/r/ceph/ceph/tags/.
# If you want to be more precise, you can always use a timestamp tag such as quay.io/ceph/ceph:v18.2.1-20240103
# If you want to be more precise, you can always use a timestamp tag such as quay.io/ceph/ceph:v18.2.2-20240311
# This tag might not contain a new Ceph version, just security fixes from the underlying operating system, which will reduce vulnerabilities
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
# Whether to allow unsupported versions of Ceph. Currently `quincy`, and `reef` are supported.
# Future versions such as `squid` (v19) would require this to be set to `true`.
# Do not set to true in production.
Expand Down
2 changes: 1 addition & 1 deletion deploy/examples/cluster-external-management.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ spec:
dataDirHostPath: /var/lib/rook
# providing an image is required, if you want to create other CRs (rgw, mds, nfs)
cephVersion:
image: quay.io/ceph/ceph:v18.2.1 # Should match external cluster version
image: quay.io/ceph/ceph:v18.2.2 # Should match external cluster version
2 changes: 1 addition & 1 deletion deploy/examples/cluster-on-local-pvc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ spec:
requests:
storage: 10Gi
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
allowUnsupported: false
skipUpgradeChecks: false
continueUpgradeAfterChecksEvenIfNotHealthy: false
Expand Down
2 changes: 1 addition & 1 deletion deploy/examples/cluster-on-pvc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
requests:
storage: 10Gi
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
allowUnsupported: false
skipUpgradeChecks: false
continueUpgradeAfterChecksEvenIfNotHealthy: false
Expand Down
2 changes: 1 addition & 1 deletion deploy/examples/cluster-stretched-aws.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
mgr:
count: 2
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
allowUnsupported: true
skipUpgradeChecks: false
continueUpgradeAfterChecksEvenIfNotHealthy: false
Expand Down
2 changes: 1 addition & 1 deletion deploy/examples/cluster-stretched.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
mgr:
count: 2
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
allowUnsupported: true
skipUpgradeChecks: false
continueUpgradeAfterChecksEvenIfNotHealthy: false
Expand Down
4 changes: 2 additions & 2 deletions deploy/examples/cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ spec:
# v17 is Quincy, v18 is Reef.
# RECOMMENDATION: In production, use a specific version tag instead of the general v17 flag, which pulls the latest release and could result in different
# versions running within the cluster. See tags available at https://hub.docker.com/r/ceph/ceph/tags/.
# If you want to be more precise, you can always use a timestamp tag such as quay.io/ceph/ceph:v18.2.1-20240103
# If you want to be more precise, you can always use a timestamp tag such as quay.io/ceph/ceph:v18.2.2-20240311
# This tag might not contain a new Ceph version, just security fixes from the underlying operating system, which will reduce vulnerabilities
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
# Whether to allow unsupported versions of Ceph. Currently `quincy` and `reef` are supported.
# Future versions such as `squid` (v19) would require this to be set to `true`.
# Do not set to true in production.
Expand Down
2 changes: 1 addition & 1 deletion deploy/examples/images.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
gcr.io/k8s-staging-sig-storage/objectstorage-sidecar/objectstorage-sidecar:v20230130-v0.1.0-24-gc0cf995
quay.io/ceph/ceph:v18.2.1
quay.io/ceph/ceph:v18.2.2
quay.io/ceph/cosi:v0.1.1
quay.io/cephcsi/cephcsi:v3.10.2
quay.io/csiaddons/k8s-sidecar:v0.8.0
Expand Down
2 changes: 1 addition & 1 deletion deploy/examples/toolbox.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
dnsPolicy: ClusterFirstWithHostNet
containers:
- name: rook-ceph-tools
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
command:
- /bin/bash
- -c
Expand Down
2 changes: 1 addition & 1 deletion design/ceph/ceph-cluster-cleanup.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ metadata:
namespace: rook-ceph
spec:
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
dataDirHostPath: /var/lib/rook
mon:
count: 3
Expand Down
4 changes: 2 additions & 2 deletions images/ceph/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ include ../image.mk
# Image Build Options

ifeq ($(GOARCH),amd64)
CEPH_VERSION ?= v18.2.1-20231215
CEPH_VERSION ?= v18.2.2-20240311
else
CEPH_VERSION ?= v18.2.1-20231215
CEPH_VERSION ?= v18.2.2-20240311
endif
REGISTRY_NAME = quay.io
BASEIMAGE = $(REGISTRY_NAME)/ceph/ceph-$(GOARCH):$(CEPH_VERSION)
Expand Down
4 changes: 2 additions & 2 deletions pkg/operator/ceph/cluster/osd/deviceset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,8 @@ func TestPVCName(t *testing.T) {
}

func TestCreateValidImageVersionLabel(t *testing.T) {
image := "ceph/ceph:v18.2.1"
assert.Equal(t, "ceph_ceph_v18.2.1", createValidImageVersionLabel(image))
image := "ceph/ceph:v18.2.2"
assert.Equal(t, "ceph_ceph_v18.2.2", createValidImageVersionLabel(image))
image = "rook/ceph:master"
assert.Equal(t, "rook_ceph_master", createValidImageVersionLabel(image))
image = ".invalid_label"
Expand Down
2 changes: 1 addition & 1 deletion tests/manifests/test-cluster-on-pvc-encrypted.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
requests:
storage: 5Gi
cephVersion:
image: quay.io/ceph/ceph:v18.2.1
image: quay.io/ceph/ceph:v18.2.2
dashboard:
enabled: false
network:
Expand Down

0 comments on commit a67d742

Please sign in to comment.