Skip to content

Commit

Permalink
docs: clarify instructions on submitting a PR
Browse files Browse the repository at this point in the history
The unit tests are not necessary if a PR is being opened for
documentation or other non-code changes, so we clarify the
instructions.

Signed-off-by: travisn <[email protected]>
  • Loading branch information
travisn committed Jun 2, 2023
1 parent 666a46c commit e631cf6
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions Documentation/Contributing/development-flow.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,9 @@ After a feature or bug fix is completed in your branch, open a Pull Request (PR)
to the [upstream Rook repository](https://github.com/rook/rook).

Before opening the PR:
- Add unit tests
- All unit tests are passing
- Rebase on the latest upstream changes

See [Unit Tests](#unit-tests) below on how to run unit tests.
- If there are code changes, add unit tests and verify that all unit tests are passing. See [Unit Tests](#unit-tests) below on running unit tests.
- Rebase on the latest upstream changes

### Regression Testing

Expand Down

0 comments on commit e631cf6

Please sign in to comment.